Strip newline in web identity token file if found #1965
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mongodb-drivers-pr-bot
bot
added
the
review-priority-low
API Change ReportNo changes found! |
|
In the meantime, I'm using this as a workaround (in case anyone else runs in to this problem: https://gist.github.com/ZackarySantana/1aedd800f0b8a55227bb79c5e3ec4ebd) |
matthewdale
requested review from
matthewdale
and removed request for
qingyang-hu
|
Additional context: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This updates the token retrieval to strip the newline if present. I'm open to any alterations if needed!
Background & Motivation
I'm using fly.io and their token files unfortunately come with a new line at the end of them. It'd be nice if I didn't have to overwrite the file to remove the newline, but instead the assume role provider was more resilient.